Codecov Report

Merging #2614 into master will decrease coverage by 0.02%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #2614      +/-   ##
==========================================
- Coverage   95.17%   95.15%   -0.03%     
==========================================
  Files         361      361              
  Lines        6658     6660       +2     
  Branches      303      303              
==========================================
  Hits         6337     6337              
- Misses        321      323       +2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 564e492...e3df750. Read the comment docs.

Thanks! Would you also add usages of the syntax to https://github.com/typelevel/cats/blob/master/binCompatTest/src/main/scala/catsBC/MimaExceptions.scala
something like
"blah".leftNec[Int]

This will make sure that such usages are still binary compatible.

once this approach is approved, I'd like to update all value classes fields to private in Cats

@kailuowang Added.

I think I've proven to myself that things still work as expected, so this should be ready for actual review.

Thanks @coltfred

@rossabaker @ceedubs @LukaJCB what do you think of this?
This is mostly to fix to the public field of value classes causing conflicts with other extensions. We had to make them public due to restrictions on scala 2.10 but we already dropped 2.10 support. If you all agree with this approach, I am going to create an issue to make all* value class fields private.

This looks very reasonable, If everything still works as is then I'm happy to change this for all the extensions. Are we going to do an 1.5.0-RC1? We could make sure everything still works with that release :)

@LukaJCB yes I think we should do a RC1

I'm more than happy to give a 1.5.0-RC1 a try today or this weekend.